Dear Gary

Thanks for your comments! I've now processed them, and you'll find
some interleaved comments below.

Lou

|From Gary_Simons@sil.org Thu Sep 20 18:38:44 2001
|Date: Wed, 19 Sep 2001 15:46:04 -0500
|From: Gary_Simons@sil.org
|To: lou.burnard@computing-services.oxford.ac.uk
|Subject: Re: TEI P4 Review, Chapter 26
|
|
|Lou,
|
|Here are my results for chapter 26.  Sorry to be so close to the deadline,
|but at least there is a day to spare.  (I just got back from a two-week
|trip to Thailand and am glad to have made it back in time.  For awhile
|there, when the airports were closed, I wasn't sure when I'd get back.)
|
|One thing I noted throughout the chapter was that the special formatting
|for tag names in the text did not come out.  In P3, they were Courier with
|surrounding < and >.  In the HTML version I reviewed, they were in the
|regular body type without < and >.  Presumably, that was a style sheet
|setting so I will not mention these below in my section by section review
|of problems, but if for some reason that information did get lost, I marked
|them as I read through so I could help you recover them if needed.

This was, as you correctly guessed, a formatting blunder, which we
have now (I think) fixed.

|
|The bulk of the errors I am reporting below are missing quotes around
|attribute values and missing slashes to close empty tags.  The instructions
|inferred that you want all the examples to be well-formed XML, but I'm not
|sure they said so in black and white.  I hope I'm not inundating you with
|more than you were looking for.

On the contrary: we did try to fix all of those things automatically,
but expected to have missed a few, which I infer you have detected, so
this is invaluable.

|
|Section 26.1
|
|First paragraph after the tag documentation for <fsDecl>, second sentence.
|It says "the fsd element", but it should be "the fsd attribute".  This
|error is also in P3.  (This is not such a good sign to start off with a
|change in wording, but I promise, this is the only one!)

Not so much a change as a long slumbering error. Good thing we are not
keeping Michael's promise about paying for errors detected in P3...

|
|Next paragraph.  There are two in-line markup examples for <fs type='...'>
|in which the attribute values should be quoted.

OK. 

|
|Example document beginning <!DOCTYPE etc.  Will the public identifier still
|be TEI P3, or should it change to P4?  

This is a widespread problem about which we havent yet made up our
collective mind.

|Within the <encodingDesc> there are
|three <fsdDecl>s.  These are empty tags missing the final />.

Looking at this again, I remembered that SUBDOC is not available in
XML, so the example as stands has to be an SGML one, so it's actually
not wrong! This chapter (and also the WSD chapter) still needs
revision on this point. I've made a bash at it, by proposing that the
FSD attribute behaves differently in SGML and XML environments. In the
latter case it can contain just an XPATH expression which will locate
the required entity, so you dont need the external entity definition
as well. &winita;


|The next paragraph of text also refers to the public identifier as TEI P3.

See above. The copyright statement also needs attention. &winita;

|
|
|Section 26.2
|
|Paragraph beginning "Feature declarations and ..."   In the in-line markup
|examples, there are 9 attribute values that need to be quoted.

Fixed


|
|The example that begins <!DOCTYPE has a public identifier with TEI P3.
|
|
|Section 26.3
|
|In the tag documentation for <fDecl>, the documentation for the org
|attribute is just one sentence.  In P3, it continues "Legal values are:"
|and then gives a bulleted list that defines the four possible values.

This is a formatting issue. The legal values are not getting displayed
for attributes anywhere in the text, though they are in fact listed in the
appendix.

|
|In the block quoted definition of subsumption (beginning "fs subsumes ...")
|there are two occurrences of fs&prime; in which the entity has not been
|replaced.

Careless editing of the ODD source. Fixed.

|
|In the next paragraph, needs quoted attribute for <fs type=X> and the <nbr>
|example is an empty tag that needs />.

OK

|
|The example that follows the paragraph beginning "As an example ..." is not
|formatted as in P3 (where it is right).  All of the lines should be
|indented, so that the "feature" and "value range" headings line up over
|their respective columns.  P3 also has an blank line after the two lines
|that are headings.

Yes, we have several formatting problems with these examples.

|
|In the example beginning <fDecl name='INV'>, the line beginning
|<plus><minus>... ought to be on the end of the preceding line (as it is in
|P3).  Also note that <plus/> (once) and <minus/> (twice) need to be empty
|tags.

fixed

|
|In the example beginning <fDecl name='CONJ'>, there are eight cases of
|<sym/> which need to be made into empty tags.

OK

|
|In the example beginning <fDecl name='COMP'>, the <vRange> has five cases
|of <sym/> which need to be made into empty tags.  In <vDefault>, the
|following should be empty tags: <sym/>, <plus/>, <then/>, and <sym/> again.

OK
|
|In the paragraph beginning, "That is, the value ...", there are three
|instances of attribute values that need to be quoted.

OK

|
|In the paragraph beginning, "This example makes use ...", there is one
|instance of an attribute value that needs to be quoted.
|

OK

|
|Section 26.4
|
|In FCR7, there is an unexapnded entity: &equiv;
|
|In the example following the paragraph beginning "The first constraint",
|<plus/>, <then/>, <plus/> again, and <sym/> are empty tags.
|
|In the example following the paragraph beginning "The second constraint",
|<sym/> and <iff/> are empty tags.

OK
|
|In the example following the paragraph beginning "The final constraint",
|<then> should be changed to <then/>, and </then> should be deleted.
|
OK (trying to be too clever...)

|
|Section 26.5
|
|The extended example is missing the /> for a number of the empty tags:
|
|In <fDecl name='INV'>, the range should be <plus/><minus/> and the default
|<minus/>
|
|In <fDecl name='COMP'>, <vDefault> needs <plus/>, <then/>, and <sym/>
|following the <then/>.
|
|Within <fsConstraints>:  <plus/> twice, <then/> twice, <iff/> once, <none/>
|once.
|
|In <fDecl name='PERS'>, <sym/> three times.
|
|In <fDecl name='NUM'>, <sym/> twice.
|

OK

|
|That's it.  Happy editing,
|-Gary
|
|

Thanks!
|
|